openframeworks / openframeworks/openFrameworks
ofNode::orbit with just long, lat, radius should be relative to parent node
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
Currently, the signatures:
(1) ofNode::orbit(longitude, latitude, radius, ofNode& centerNode)
and
(2) ofNode::orbit(longitude, latitude, radius, const ofVec3f& centerPoint = ofVec3f(0, 0, 0))
result in
ofNode::orbit(longitude, latitude, radius, ofVec3f(0, 0, 0))
being resolved for a call like in:
mNode = ofNode();
mNode1 = ofNode();
mNode1.setParent(mNode);
mNode.truck(100);
float angle = 90 + ofGetFrameNum() % 360;
mNode1.orbit(angle, 0, 100);
This seems counter-intuitive, as you may assume a parented node to orbit around its parent. In the above case, the parented node mNode1 will rotate around the centre of the universe, world (0,0,0) instead of its parent's centre, (100,0,0). This because the default argument in signature (2) will be used.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ofNode::orbit overloads and read how the three-argument call is resolved when a node has a parent. Reproduce the example with mNode1 parented to mNode, then verify that orbiting with only longitude, latitude, and radius uses the parent node's center rather than world (0,0,0).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100