openframeworks / openframeworks/openFrameworks

ofNode::orbit with just long, lat, radius should be relative to parent node

Open
#4,976 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

section-3D
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

Currently, the signatures:
(1) ofNode::orbit(longitude, latitude, radius, ofNode& centerNode)
and
(2) ofNode::orbit(longitude, latitude, radius, const ofVec3f& centerPoint = ofVec3f(0, 0, 0))
result in
ofNode::orbit(longitude, latitude, radius, ofVec3f(0, 0, 0))
being resolved for a call like in:

mNode = ofNode();
mNode1 = ofNode();
mNode1.setParent(mNode);
mNode.truck(100);
float angle = 90 + ofGetFrameNum() % 360;
mNode1.orbit(angle, 0, 100);

This seems counter-intuitive, as you may assume a parented node to orbit around its parent. In the above case, the parented node mNode1 will rotate around the centre of the universe, world (0,0,0) instead of its parent's centre, (100,0,0). This because the default argument in signature (2) will be used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the ofNode::orbit overloads and read how the three-argument call is resolved when a node has a parent. Reproduce the example with mNode1 parented to mNode, then verify that orbiting with only longitude, latitude, and radius uses the parent node's center rather than world (0,0,0).

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.