openframeworks / openframeworks/openFrameworks
ofBaseVideo::load and ofBaseVideo::loadAsync should take const std::string&.
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
This is a const-correctness issue to be addressed after the doc-sprint.
This will affect the following files.
- ofVideoPlayer
- ofAVFoundationPlayer
- ofxiOSVideoPlayer
- ofQtKitPlayer
- ofQuicktimePlayer
- ofDirectShowPlayer
- ofGstVideoPlayer
...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ofBaseVideo::load and loadAsync plus the implementations listed: ofVideoPlayer, ofAVFoundationPlayer, ofxiOSVideoPlayer, ofQtKitPlayer, ofQuicktimePlayer, ofDirectShowPlayer, and ofGstVideoPlayer. Review the related declarations and implementations first; done means the affected methods consistently take const std::string& across the listed players.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100