openframeworks / openframeworks/openFrameworks
ofSerial::readByte not returning OF_SERIAL_NO_DATA on Windows
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I believe that moving this block to outside both TARGET_OSX and TARGET_WIN32 would fix the issue.
if(nRead == 0){
return OF_SERIAL_NO_DATA;
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ofSerial::readByte implementation and inspect the TARGET_OSX and TARGET_WIN32 guards around nRead. Confirm that a zero-byte read on Windows returns OF_SERIAL_NO_DATA, then verify the existing serial behavior or tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100