openframeworks / openframeworks/openFrameworks
Rename ofGetLastFrameTime
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I had for some time wondered why there was no ofGetDeltaTime() that returns the delta time from last from to current frame, until I now realized that ofGetLastFrameTime() does exactly this (after looking in its source).
In my view it has a very bad name, i expected to get the absolute time of the last frame (I was about to calculate the delta time my self using ofGetElapsedTimef() - ofGetLastFrameTime() when i realized my mistake).
Am I the only misunderstanding its name?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the source implementation of ofGetLastFrameTime() and compare it with ofGetElapsedTimef() to confirm the naming concern. Review the seven-comment discussion for a decision on the replacement name; done means an agreed API rename with all affected references updated, if the project accepts the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, developer-experience
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100