openframeworks / openframeworks/openFrameworks

Addon dependencies include order in make

Open
#4,568 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

addon android waiting-for-feedback
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

I just added an dependency in ofxCv to ofxOpenCV, but in make based build systems this has an issue, ofxCv gets included before ofxOpenCV in the linking phase, it should be opposite, dependencies should get included first.

I've tried to move the dependency includer in config.addons.mk around a bit, but haven't found a place where it works.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in config.addons.mk and reproduce a make-based build using the ofxCv dependency on ofxOpenCV. Trace how addon dependencies are included during linking; done means dependency addons are included before the addons that depend on them.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, opencv
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.