openframeworks / openframeworks/openFrameworks
ofNode::setTransformMatrix is ambigous
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
see original conversation at https://github.com/openframeworks/openFrameworks/pull/4066
is ofNode::setTransformMatrix ambiguous? Not clear if it's setting Local Transform or Global Transform.
We have:
getLocalTransformMatrix(), getGlobalTransformMatrix(),
setPosition, setGlobalPosition, setOrientation, setGlobalOrientation
so perhaps a setGlobalTransformMatrix would make it clearer?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the original conversation in pull request 4066 and compare ofNode::setTransformMatrix with the mentioned local and global transform accessors. Resolve whether the method is local or global, then make the API naming or documentation unambiguous; done means callers can clearly identify the transform scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100