openframeworks / openframeworks/openFrameworks
ofAppEGLWindow.cpp returns NULL, should be cast.
Open
Nobody has claimed this yet.
bitesize
bug
core
prelim-analysis
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
This warning arises on non armv7l and other non-raspberry pi systems.
Should be (I think) as EGLNativeWindowType is type long unsigned int:
return (EGLNativeWindowType)0;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open libs/openFrameworks/app/ofAppEGLWindow.cpp and inspect the returns at lines 403 and 413, where the warning is reported on non-armv7l and non-Raspberry Pi systems. Confirm the return type of EGLNativeWindowType and verify that both returns compile without the warning on an affected platform.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100