openframeworks / openframeworks/openFrameworks
no error message logged in ofShader::getUniformLocation
Open
Nobody has claimed this yet.
core
feature
section-2D
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
when trying to set a uniform, I miss-spelled the uniform name.
// this is wrong
shader.setUniform1f("Raduis", 40.0);
// should have been
shader.setUniform1f("Radius", 40.0);
But no error message was logged to the console that the Uniform is not active in the shader
It took a while to debug. Please add the error check.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the implementation of ofShader::getUniformLocation and inspect how setUniform1f handles a missing uniform. Reproduce the misspelled-uniform example; done means the console reports that the uniform is not active in the shader.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100