openframeworks / openframeworks/openFrameworks

ofMesh::sphere is not a closed mesh

Open
#2,740 1 comment 0 reactions 1 assignee View on GitHub

@julapy is already working on this.

Since Dec 20, 2013.

core feature section-3D
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

noticed the other day that the ofMesh::sphere is not being created as a closed mesh,
which i think it should be. the first and last row of vertices are being duplicated, when i think they should be the same and joined.

all the 3d software that ive used create a sphere primitive as a closed mesh and i think this is the standard.

i can make this change but just wanted to throw it out there first in case someone has a strong opinion against this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.