openframeworks / openframeworks/openFrameworks
PROJECT_EXCLUSIONS not working properly if sub-folders contain spaces
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
If I have a folder containing some sub-folders with a space on their names, those are not filtered out when using PROJECT_EXCLUSIONS.
Example:
/
/src/
/something/
/something/some thing/
with PROJECT_EXCLUSIONS = $(PROJECT_ROOT)/something% , thing/ gets leaked into the path list.
This is not usually a problem, unless this sub-folder has invalid characters such as (. Then is not possible to compile as those are leaked in the compiling command.
For now I just filter out all paths with spaces by adding | grep -v " " in https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworksCompiled/project/makefileCommon/config.project.mk#L263 but I feel that this is an ugly hack.
Anyway, having sub-folders with spaces breaks the expected behaviour!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in libs/openFrameworksCompiled/project/makefileCommon/config.project.mk around line 263 and trace how PROJECT_EXCLUSIONS is applied to paths containing spaces. Verify that sub-folders with spaces are excluded without filtering all paths containing spaces, and check the resulting compile path list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100