openframeworks / openframeworks/openFrameworks
ofRectangle is not PoD
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I need a PoD ofRectangle, (for speed) and currently there is a virtual destructor so there's a vtable. Is this neccessary?
I've not seen anything that extends it AND uses any virtuals... (and nothing is declared virtual)
Other of PoD types like ofColour, ofVecXX, even ofPixels don't have virtual destructors...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ofRectangle definition and reviewing its destructor, inheritance, and usages. Check the issue discussion for any constraints around extending the type or using virtual methods, then verify that the resulting type meets the requested POD goal without breaking existing uses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100