openframeworks / openframeworks/openFrameworks
copying ofShader does not create a new GL shader (in 0.7.4)
Open
Nobody has claimed this yet.
bug
core
section-3D
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
If you assign an ofShader to another ofShader and the original ofShader gets destructed, the GL program will be unloaded and it won't be reloaded by the new ofShader.
Fix would be to write an ofShader copy constructor (assignment operator?) to handle this case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ofShader copy and assignment implementations and the code that unloads its GL program. Reproduce assigning one ofShader to another, destroy the original, and verify that the remaining shader still retains or reloads a usable GL program.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100