openframeworks / openframeworks/openFrameworks
ofOpenALSoundPlayer inconsistent checks for multiplay vs loop
Open
Nobody has claimed this yet.
bug
code-review
core
section-sound
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
ofOpenALSoundPlayer::setLoop checks for multiplay and aborts of multiplay is true, but setMultiplay doesn't check for loop and abort if looping is set.
this check is perhaps better performed on the ofSoundPlayer before passing on the actual player instance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing ofOpenALSoundPlayer::setLoop and setMultiplay, then trace how ofSoundPlayer passes requests to the underlying player. Clarify the intended interaction between looping and multiplay and whether validation belongs in ofSoundPlayer or the concrete player; done means both entry points apply consistent behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100