openframeworks / openframeworks/openFrameworks
ofOpenALSoundPlayer::loadSound leaks memory on error conditions
Open
Nobody has claimed this yet.
bug
code-review
core
prelim-analysis
section-sound
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
in the if (err != AL_NO_ERROR) blocks, no close/unstream/alDeleteSources calls are made.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ofOpenALSoundPlayer::loadSound and inspect each if (err != AL_NO_ERROR) path. Compare the resources acquired before each error check with the cleanup performed on success, then ensure the error paths release the relevant resources. Done means the reported close, unstream, and alDeleteSources leaks are addressed without changing successful loading behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100