openframeworks / openframeworks/openFrameworks
ofOpenALSoundPlayer sfReadFile, mpg123ReadFile and mpg123Stream error conditions can leak memory
Open
Nobody has claimed this yet.
bug
code-review
core
prelim-analysis
section-sound
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
should call sf_close before return false, or mpg123_delete and mpg123_close
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the audio code for ofOpenALSoundPlayer and the sfReadFile, mpg123ReadFile, and mpg123Stream functions. Trace each failure return and confirm that the corresponding audio resource is closed or deleted before returning false; done means the failure paths no longer leak memory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100