openframeworks / openframeworks/openFrameworks
code repetition about orientation in ofGLRenderer.cpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
this code for orientation seems to be included twice, it's a bit redundant to have it in both places and would be good to include it once so that if we need to fix it, we don't have it written multiple places:
https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/gl/ofGLRenderer.cpp#L370-420
https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/gl/ofGLRenderer.cpp#L458-507
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in libs/openFrameworks/gl/ofGLRenderer.cpp and compare the orientation-related code at lines 370-420 and 458-507. Consolidate the repeated logic without changing either path's behavior, then build or test the renderer to verify both locations still handle orientation correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100