openframeworks / openframeworks/openFrameworks
ofPixels::copyFrom needs a re-write
Open
Nobody has claimed this yet.
code-review
core
prelim-analysis
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
this function looks problematic -- there's a sizeof(float) which could be bad where sizeof(int) == sizeof(float), and there's a potential to use memcpy elsewhere in the funciton. also some ternary operators that look odd. it also could be really commented fully.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation and callers of ofPixels::copyFrom; start by reading its current size handling, memcpy opportunities, ternary expressions, and comments. Because no file, test, or exact behavior is specified, agree on the intended rewrite and validation criteria before changing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100