openframeworks / openframeworks/openFrameworks

ofRenderCollection seems redundant

Open
#1,563 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code-review core feature
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

in the group review we started to discuss ofRenderCollection and if it was really necessary as a file -- it's alot of reimplementation of code and it means that as we make changes to the render pipeline, there's now three places we need to change it (in the ofCore, in the render and in the collection).

also, the name "ofRenderCollection" feels very java :)

Could we move the logic of ofRenderCollection closer into OF, ie, ? At the moment, there's for sure something repetitive happening here, and if multiple renders is something we really care about and wish to support, we could switch all the calls that do:

renderer->

to

for (int i = 0; i < renders.size(); i++){ }

and just remove this file?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the repeated rendering logic in ofRenderCollection, ofCore, and the render implementation. Trace the renderer-> call sites and determine how multiple renders should be supported; the refactor is done when the redundant collection logic is removed or consolidated without leaving those call sites inconsistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.