openframeworks / openframeworks/openFrameworks

Smoothing and additive blending

Open
#1,546 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core feature section-internals
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

Hi guys!

I'm not sure why but as soon as you enable smoothing, additive blending is disabled. In fact I think someone on the team is also unsure - see the comment "why do we need this?" in libs/openFrameworks/gl/ofGLRenderer.cpp :)

//----------------------------------------------------------
void ofGLRenderer::startSmoothing(){
    #ifndef TARGET_OPENGLES
        glPushAttrib(GL_COLOR_BUFFER_BIT | GL_ENABLE_BIT);
    #endif

    glHint(GL_LINE_SMOOTH_HINT, GL_NICEST);
    glEnable(GL_LINE_SMOOTH);

    //why do we need this?
    glEnable(GL_BLEND);
    glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
}

I commented it out and it seemed to work OK, but I'm sure there are other repercussions. But it would be nice to have smoothing and blendmodes.

cheers
Seb

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in libs/openFrameworks/gl/ofGLRenderer.cpp at ofGLRenderer::startSmoothing() and inspect how smoothing changes blending state. Reproduce the interaction between smoothing and additive blending, then check the surrounding renderer state handling for repercussions. Done means smoothing and blend modes can be used together without unexpectedly replacing the selected blend mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.