openframeworks / openframeworks/openFrameworks

ofDrawBitmapStringHighlight doesn't respect ofDrawBitmapMode

Open
#1,514 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug core prelim-analysis section-internals section-typography
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

Hey @kylemcdonald, this occurs when drawing inside of an fbo when using the default OF_BITMAPMODE_MODEL_BILLBOARD

        ofDrawBitmapStringHighlight(s,p);

Basically, I think the ofRect here needs the same ofDrawBitmapMode dependent view treatment that the bitmap string gets here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rectangle handling in libs/openFrameworks/graphics/ofGraphics.cpp near line 1150 and compare it with the bitmap string view handling in libs/openFrameworks/gl/ofGLRenderer.cpp near line 1061. Verify the fix by drawing ofDrawBitmapStringHighlight inside an FBO with the default OF_BITMAPMODE_MODEL_BILLBOARD and confirming the highlight rectangle follows the bitmap mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.