openframeworks / openframeworks/openFrameworks

ofFbo bind() and unbind() is confusing

Open
#1,359 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core development-strategy feature section-internals
Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

fbo.bind() should bind the FBO's texture, ie behave the same way as ofTexture.bind(). At the moment it actually binds the FBO's framebuffer. this is confusing, and the documentation is inaccurate on this point (http://www.openframeworks.cc/documentation/gl/ofFbo.html#bind).

i would suggest making bind() call getTextureReference().bind(), and adding a new function bindFrameBuffer to do what bind() currently does. comments?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ofFbo::bind(), getTextureReference(), and the ofFbo documentation linked in the issue. Review the existing bind behavior and related API comments before deciding how the framebuffer operation should be exposed. Done means the texture-binding behavior and framebuffer-binding API are consistent with the documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.