openframeworks / openframeworks/openFrameworks
ofArduino macros
Open
@bakercp is already working on this.
Since May 23, 2017.
bug
core
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I had some problems because of macro definitions in ofArduino.h overriding an enum in a a class of my codebase ( SHIFT )
It's not exactly a bug! but I would suggest using enums or const int instead of the macros to avoid any conflicts
I solved the problem by modifying
define SHIFT 0x05
into
const int SHIFT = 0x05;
another solution could be using enumerations as
enum
{
...
SHIFT = 0x05,
etc...
};
I believe this would not break any of the existing code
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.