openframeworks / openframeworks/openFrameworks
ofShader should show an error when using an invalid name
Open
Nobody has claimed this yet.
bug
core
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
if you have:
uniform float dog;
float cat;
and:
shader.setUniform1f("dog", ofGetElapsedTimef());
shader.setUniform1f("cat", ofGetElapsedTimef());
there is no currently no error printed to the console, and "cat" is mysteriously unchanging while "dog" is fine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the shader.setUniform1f calls shown in the issue and trace how uniform names are looked up and handled. Check the existing console error behavior around invalid names; done means an invalid name reports an error while the valid uniform continues to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100