Consider updating user/object regex validation
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 27
- Forks
- 24
- Avg merge
- 12d 6h
- Merged PRs (30d)
- 1
Description
the regexes are not checking for character length or many characters that are likely invalid such as Unicode control characters like U+0000 (null).
Originally posted by @senojj in https://github.com/openfga/openfga/pull/1825#discussion_r1718941081
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the user and object regex definitions in openfga/v1/openfga_service.proto around lines 1134-1159. First determine the intended length limits and character policy, including Unicode control characters such as U+0000; the work is done when those agreed validation rules are represented by the regexes and verified against valid and invalid examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100