Remove leaking logs from CLI proxy package
@viveksyngh is already working on this.
Since Feb 6, 2021.
- Dominant language
- Go
- Stars
- 816
- Forks
- 230
- Avg merge
- 6h 4m
- Merged PRs (30d)
- 1
Description
As proxy package is used as SDK it should remove all logging and should return those outputs as results from those API
Expected Behaviour
It should not leak logs when SDK are called.
Current Behaviour
It is having some print/log statements like
Possible Solution
Remove these print statements
Standardised API results to provide more information to the callers
TODO - Share API format results
Steps to Reproduce (for bugs)
Context
Your Environment
-
FaaS-CLI version ( Full output from:
faas-cli version): -
Docker version ( Full output from:
docker version): -
Are you using Docker Swarm (FaaS-swarm ) or Kubernetes (FaaS-netes)?
-
Operating System and version (e.g. Linux, Windows, MacOS):
-
Link to your project or a code example to reproduce issue:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.