openfaas / openfaas/faas-cli

Feature: Add memory/cpu configuration to "store deploy"

Open
#670 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
816
Forks
230
Avg merge
6h 4m
Merged PRs (30d)
1

Description

If I want to apply a memory limit, or CPU limit I would need to create YAML file and deploy my function.

Expected Behaviour

I would like to directly apply the CPU/memory limit of a function.

Current Behaviour

You need to define them in stack the yaml.

Possible Solution

Add two new flags to the deploy command in here my suggestion would be --cpu 10m --memory 20m which will overwrite the place above, the priority should be discussed I would go with command>yaml

Steps to Reproduce (for bugs)

It is not a bug, per se

Context

Requested

Your Environment

  • FaaS-CLI version ( Full output from: faas-cli version ):
    N/A
  • Docker version ( Full output from: docker version ):
    N/A
  • Are you using Docker Swarm (FaaS-swarm ) or Kubernetes (FaaS-netes)?
    N/A
  • Operating System and version (e.g. Linux, Windows, MacOS):
    N/A
  • Link to your project or a code example to reproduce issue:
    N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in commands/deploy.go at the deploy command entry point linked by the issue, then trace how stack YAML resource settings are read and sent during deployment. Define the expected precedence between the new CPU and memory flags and YAML values; done means store deploy can apply both limits directly without requiring those values in the YAML file.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.