Add Rio to faas-cli generate
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 816
- Forks
- 230
- Avg merge
- 6h 4m
- Merged PRs (30d)
- 1
Description
Expected Behaviour
The following should generate a Rancher Rio Service definition:
faas-cli generate --api=services.rio.cattle.io
apiVersion: rio.cattle.io/v1
kind: Service
metadata:
name: figlet
namespace: default
spec:
concurrency: 10
cpus: "0"
env:
- name: a
value: b
image: functions/figlet:latest
imagePullPolicy: IfNotPresent
maxScale: 1
minScale: 1
ports:
- port: 8080
protocol: HTTP
targetPort: 8080
rollout: true
rolloutIncrement: 5
rolloutInterval: 5
scale: 1
weight: 100
Current Behaviour
We have OpenFaaS CRD and Knative Serving CRD in place. I'd like to see the Rio CRD there next.
Possible Solution
Copy the approach used for the current generation as per: https://github.com/openfaas/faas-cli/blob/master/commands/generate.go#L164
Set all default / minimum needed to get a service running.
- Install K8s somewhere
- Install Rio - https://github.com/rancher/rio
- Try
kubectl applyfor the sample YAML above - Next update the faas-cli code to generate Service YAML
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in commands/generate.go around line 164 and review the existing CRD generation approach. Install Kubernetes and Rio, then apply the sample YAML to verify the required Service fields. Done means faas-cli generate --api=services.rio.cattle.io produces the shown Rio Service definition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100