openfaas / openfaas/faas-cli

refactor TLS warning messages

Open
#597 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

design/review priority/low
Dominant language
Go
Stars
816
Forks
230
Avg merge
6h 4m
Merged PRs (30d)
1

Description

TLS warning messages should be refactored to a more flexible approach

Expected Behaviour

something like

checkTLS(io.Writer, gateway, tlsenabled)

should validate and print the warning

Current Behaviour

There is a return statement and extra \n

Possible Solution

please refer to #581

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the approach referenced in #581 and locating the current TLS warning path in the CLI. Compare it with the proposed checkTLS(io.Writer, gateway, tlsenabled) entry point; done means TLS validation and warning output use a more flexible approach without the current return statement or extra newline.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.