openfaas / openfaas/faas-cli

Error behaviour for when a parallel faas-cli build fails

Open
#214 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
816
Forks
230
Avg merge
6h 4m
Merged PRs (30d)
1

Description

This issue discusses error behaviour for when a parallel faas-cli build fails.

I was building the samples in the main faas repo using the YAML file, one of them failed and printed red text but it was really hard to see and I could have missed it.

I thought we had already done work to break out upon an error and give a non-zero exit code.

How do we want this to work?

Scenario 1 - sequential

You're building 5 functions sequentially from a YAML file - number 3 fails, should we break out and stop?

Scenario 2 - parallel

You're building the same stack with --parallel=4 and output is intermingled. Do we break out all builds as soon as one of them produces an error?

Solutions

  • Break out of either flow upon first error
  • Push on and summarise a list of functions built in an ASCII table:
function time taken build
hubstats 1m 10s error
markdown 59s OK

Other considerations

Headless use of faas-cli build in CI

@developius @itscaro @rgee0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with faas-cli build using the YAML file, both sequentially and with --parallel=4. Review the existing build entry points and error handling, then clarify the desired stop-or-continue behavior, summary output, and non-zero exit status before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.