openedx / openedx/xblocks-core

Flaky VideoBlock JS tests

Open
#290 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

flaky-test
Dominant language
Python
Stars
0
Forks
15
Avg merge
5d 16m
Merged PRs (30d)
7

Description

Several VideoBlock karma tests seem to be flakey.

By my estimate, one of any of these fails around 10% of the time.

1) player state was changed
     Video HTML5Video non-hls encoding on non-Touch devices  events: [play]
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. in http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d (line 3938)
QueueRunner.prototype.run/attemptAsync/timeoutId<@http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d:3938:23
2) callback was called
     Video HTML5Video non-hls encoding on non-Touch devices  events: [play]
     Expected [ 3, 1 ] to contain -1.
../tests/js/html5_video_spec.js/</</describeInfo</</</</<@http://localhost:9876/base/public/js/commons.js?70e765de13f56a983143d5c15cc43f401e110fe8:65273:72
Deferred/then/</</<@http://localhost:9876/base/assets/js/src/vendor/jquery.js?26e6b63b81813d8ad942c90d369df2673602b812:3366:33
fire@http://localhost:9876/base/assets/js/src/vendor/jquery.js?26e6b63b81813d8ad942c90d369df2673602b812:3187:31
fireWith@http://localhost:9876/base/assets/js/src/vendor/jquery.js?26e6b63b81813d8ad942c90d369df2673602b812:3317:7     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. in http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d (line 3938)
QueueRunner.prototype.run/attemptAsync/timeoutId<@http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d:3938:23
3) callback was called
     Video HTML5Video hls encoding on non-Touch devices  events: [play]
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. in http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d (line 3938)
QueueRunner.prototype.run/attemptAsync/timeoutId<@http://localhost:9876/absolute/home/runner/work/xblocks-core/xblocks-core/node_modules/jasmine-core/lib/jasmine-core/jasmine.js?da99c5b057693d025fad3d7685e1590600ca376d:3938:23

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/js/html5_video_spec.js and run the VideoBlock Karma tests that cover HTML5Video HLS and non-HLS playback on non-Touch devices. Investigate the reported async timeout and callback results for the play event, then verify the affected tests pass consistently across repeated runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.