openedx / openedx/sample-plugin
Add fonts to brand-sample
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 4
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 8
Description
When I changed the brand to "autumn" (https://github.com/openedx/sample-plugin/pull/47), I'd originally had it change the fonts, too. It kinda worked, in that the CSS rules pointed to my custom fonts. But, it failed because I wasn't shipping the fonts to the browser. So, CSS rules like font-family: Playfair, Georgia; just always fell back to pre-loaded web fonts like Georgia.
We should show an example of how to properly override the font to something other than a web-safe font like Georgia.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the brand-sample implementation and the existing autumn CSS rules. Trace how its custom fonts are referenced and packaged for the browser; done means the sample demonstrates an autumn font that loads instead of falling back to Georgia or another web-safe font.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100