[Fix] Popover: add border to arrow
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 140
- Forks
- 100
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 30
Description
The popover arrow border is lighter than the border for the rest of the popover.
Desired behavior
Set the popover arrow color to match the rest of the popover border.
Fix shape
in popover.json, line 22 where the arrow border is defined, remove
"modify": [{ "type": "alpha", "amount": 0.05 }],
the source token color.popover.border already has 20% alpha applied, so the modify is further reducing opacity making it render much lighter than the rest of the border
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open popover.json and inspect line 22, where the arrow border is defined. Remove the additional alpha modification described in the issue, then verify that the arrow border matches the rest of the popover border in the rendered component.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100