`isOverflowVisible` not required on `AlertModal`
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 140
- Forks
- 100
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 30
Description
https://github.com/openedx/paragon/pull/3503 added this as a required prop for ModalDialog, but it seems MFEs have gotten away with continuing to not specify the value on AlertModals.
I noticed this because of a snapshot mismatch on https://github.com/openedx/frontend-app-account/pull/1266.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the AlertModal and ModalDialog prop definitions, using PR 3503 for the change that made isOverflowVisible required. Reproduce or inspect the snapshot mismatch referenced in frontend-app-account PR 1266; done means AlertModal consumers no longer fail or produce the unintended mismatch when the prop is omitted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100