[Paragon 23] CSS build files remove duplicated properties cousing errors in modal container min-height
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 140
- Forks
- 100
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 30
Description
The modal styles has 2 min-height properties to make it browser compatible
But after compiling the css files this one only has the second value as you can see if you search for the class here
This is caused for postcss-combine-duplicated-selectors configuration
At the moment I see this affects the modal container styles but not sure if others styles too.
Possible solution
- Use
removeDuplicatedValuesinstead, in this way the plugin only marge the values when are equal.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/Modal/index.scss and the postcss-combine-duplicated-selectors configuration in lib/build-scss.js. Build the CSS and compare the modal container output in dist/core.css, then inspect whether other duplicated properties are affected. Done means compatible min-height declarations are preserved without incorrectly merging differing values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, scss
- Domain
- build-system, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100