pii_check may not really be checking

Here is the code for pii_check:

• https://github.com/openedx/openedx-platform/blob/7c68f1d255b3d56c99e6ea9e73f484e5aae5957e/Makefile#L177-L191
  • This uses --app_name cms, which doesn't seem to be matching anything.
  • Also, line 177 has comment about "Re-enable --lint flag", which seems to already be done?

Possibly the target might be missed, given we don't seem to really have been checking?

• https://github.com/openedx/openedx-platform/blob/7c68f1d255b3d56c99e6ea9e73f484e5aae5957e/.pii_annotations.yml#L4

Relevant recent issues and docs:

• https://github.com/openedx/openedx-platform/issues/35775
• https://docs.openedx.org/projects/edx-platform/en/latest/decisions/0021-fixing-quality-and-js-checks.html#pii-check

In addition to fixing, maybe we could implement or ticket ensuring this doesn't regress again? It seems this isn't the first time this broke and no one noticed.