openedx / openedx/openedx-platform
Unpin social-auth-core==4.7.0 Constraint
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.2k
- Forks
- 4.4k
- Avg merge
- 6d 18h
- Merged PRs (30d)
- 42
Description
Between 4.7.0 and 4.8.1 there was a change to the parameters for the SAMLIdentityProvider class that we override in common/djangoapps/third_party_auth/saml.py
This broke the tests for that subclass but will also likely impact anywhere where we instantiate that class.
The upstream change is: https://github.com/python-social-auth/social-core/pull/1284
We need to understand and update our code to use the new class instantiation signature which also passes in a backend to the provider.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in common/djangoapps/third_party_auth/saml.py and review the SAMLIdentityProvider subclass and its instantiation points against the upstream social-core change in PR 1284. Run the tests covering that subclass, update the affected usage for the new backend argument, and confirm the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- authentication, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100