openedx / openedx/openedx-platform

Split up Catalog MFE DEPR and link to new `MFE_CONFIG` fallback DEPR in code

Open
#37,210 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.2k
Forks
4.4k
Avg merge
6d 18h
Merged PRs (30d)
42

Description

Overall DEPR for Legacy Home/Course Catalog/Course About pages: https://github.com/openedx/edx-platform/issues/36785

PR adding MFE_CONFIG fallbacks: https://github.com/openedx/edx-platform/pull/37130

MFE_CONFIG values that will be eventually DEPRECATED
ENABLE_COURSE_SORTING_BY_START_DATE

Current behavior:

  1. pull ENABLE_COURSE_SORTING_BY_START_DATE from SiteConfiguration
  2. Use backoff value from settings.FEATURES["ENABLE_COURSE_SORTING_BY_START_DATE"]
HOMEPAGE_PROMO_VIDEO_YOUTUBE_ID
  1. pull homepage_promo_video_youtube_id from SiteConfiguration
  2. Do not use any backoff value settings. Returns None as a backoff value.
HOMEPAGE_COURSE_MAX
  1. pull HOMEPAGE_COURSE_MAX from SiteConfiguration
  2. Use backoff value from settings.HOMEPAGE_COURSE_MAX
COURSE_ABOUT_TWITTER_ACCOUNT
  1. pull course_about_twitter_account from SiteConfiguration
  2. Use backoff value from settings.PLATFORM_TWITTER_ACCOUNT
NON_BROWSABLE_COURSES
  1. Do not pull any values from SiteConfiguraion
  2. Use the reversed value of settings.FEATURES.get("COURSES_ARE_BROWSABLE")
not settings.FEATURES.get("COURSES_ARE_BROWSABLE")
ENABLE_COURSE_DISCOVERY
  1. Do not pull any values from SiteConfiguraion
  2. Use the value from settings.FEATURES["ENABLE_COURSE_DISCOVERY"]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.