openedx / openedx/openedx-platform

cleanup direct model imports from certificates djangoapp

Open
#36,647 4 comments 0 reactions 1 assignee View on GitHub

@wgu-ram-chandra is already working on this.

Since May 2, 2025.

good first issue help wanted
Dominant language
Python
Stars
8.2k
Forks
4.4k
Avg merge
6d 18h
Merged PRs (30d)
42

Description

There are a small number of direct imports from the certificates djangoapp's models.py. Wherever possible, we want to use the app's API) or data classes for use outside of the certificates app itself.

As of this writing, this appears to be all imports of the app that are not from api.py, data.py, test factories, the signals, or an exception definition:

the majority of them appear to be in legacy front-ends, unsurprisingly.

Acceptance Criteria
  • create any necessary data classes to get rid of direct imports of lms.djangoapps.certificates.models from outside the django app
  • change the code to reference the appropriate data class or API method
  • if it is difficult, costly, or impossible to make the change, consider adding a comment explaining why
  • verify that all the affected apps still work properly, and that all the tests pass

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.