openedx / openedx/openedx-platform
Ensure JS tests don't fail silently
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.2k
- Forks
- 4.4k
- Avg merge
- 6d 18h
- Merged PRs (30d)
- 42
Description
While working on the node 18 upgrade, I was able to get the JS tests CI check to pass with the application in a non-working state. After a bit of investigation, I found there were a couple test suites that weren't running due to webpack build issues. We should ensure that a test suite that doesn't run due to a build issue fails CI as opposed to silently passing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the JavaScript tests CI check and the webpack build issues that caused test suites not to run. Identify how those failures are currently reported, then verify that a suite blocked by a build issue makes the CI check fail rather than pass silently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, webpack
- Domain
- build-system, ci-cd, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100