openedx / openedx/openedx-platform

Dismiss for Discussions x-blocks deprecation banner in Studio causes 500 error message

Open
#34,483 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
8.2k
Forks
4.4k
Avg merge
6d 18h
Merged PRs (30d)
42

Description

edx.cms  | 2024-04-08 09:42:28,266 ERROR 32 [django.request] [user None] [ip None] log.py:241 - Internal Server Error: /course/course-v1:RG+New-course-2+2024
edx.cms  | Traceback (most recent call last):
edx.cms  |   File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 55, in inner
edx.cms  |     response = get_response(request)
edx.cms  |   File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/base.py", line 197, in _get_response
edx.cms  |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
edx.cms  |   File "/usr/lib/python3.8/contextlib.py", line 75, in inner
edx.cms  |     return func(*args, **kwds)
edx.cms  |   File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/contrib/auth/decorators.py", line 23, in _wrapper_view
edx.cms  |     return view_func(request, *args, **kwargs)
edx.cms  |   File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/course.py", line 301, in course_handler
edx.cms  |     raise NotImplementedError()
edx.cms  | NotImplementedError
edx.cms  | [08/Apr/2024 09:42:28] "DELETE /course/course-v1:RG+New-course-2+2024 HTTP/1.1" 500 245031

This error concerns the Dismiss button:

Знімок екрана 2024-04-08 о 13 41 21

This error occurs here:

elif request.method == 'DELETE':
    raise NotImplementedError()

This banner was added in this MR. But the backend part was not prepared for this at all.

Hello, @muhammadadeeltajamul, You have been working on this task. Can you tell me if there are plans to continue this work? Would it be possible to add a variable to control the display of the banner? It could help manage user preferences or control this content.
As I understand it, in the current implementation the Dismiss button is not needed at all.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at cms/djangoapps/contentstore/views/course.py around line 301 and trace the DELETE request triggered by the Studio Discussions x-blocks banner. Review pull request 31645 and the existing issue discussion to determine whether Dismiss should be removed or supported. Done means the banner action no longer produces a 500 response and its intended behavior is covered by the relevant project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.