openedx / openedx/i18n-tools

Feature: Allow pulling unreviewed entries when running `$ i18n_tool transifex pull`

Open
#96 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
36
PR merge metrics
No merged PRs in 30d

Description

What this helps

This allows fork maintainers to chose whether to pull unreviewed entries or not. Currently it's hardcoded:

https://github.com/edx/i18n-tools/blob/95897b0126380ea4ac6dabd422862067102bc152/i18n/transifex.py#L56-L60

User story
  • As a fork maintainer, I would like to pull the release resources (e.g. Koa) and including unreviewed entires.
What about i18n_tool pull_all?

This command would work, but it doesn't allow to specifiy which resource to pull.

Root cause: review status gone missing for release resources

The root cause of this issue is that when release files are made, they're often marked in bulk as "unreviewed" instead of copying the "reviewed" status from the "master" Transifex resources.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in i18n/transifex.py at lines 56-60 and trace how i18n_tool transifex pull selects a resource and review status. Check the command's existing options and related tests, if present. Done means a fork maintainer can choose a specific resource and whether unreviewed entries are pulled without changing the existing default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, localization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.