openedx / openedx/frontend-build

Support brand packages that don't include core paragon themes

Open
#652 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
25
Forks
41
Avg merge
3d 14h
Merged PRs (30d)
5

Description

getParagonThemeCss (as well as a few other spots) assume installed brand packages include core themes and will fail when presented with a brand package that is aliased without them.

Ideally a brand package with a few overrides could have the following theme-urls.json

{
  "themeUrls": {
    "defaults": {
      "light": "light"
    },
    "variants": {
      "light": {
        "paths": {
          "default": "./light.css",
          "minified": "./light.min.css"
        }
      }
    }
  }
}

and still work when installed using an npm alias.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading getParagonThemeCss and the other spots that assume brand packages contain core themes. Reproduce the issue with the provided theme-urls.json structure and an npm-alias installation. Done means a brand package containing only overrides loads its light theme without failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.