openedx / openedx/frontend-build

`sass-loader` legacy JS API deprecation

Open
#638 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
25
Forks
41
Avg merge
3d 14h
Merged PRs (30d)
5

Description

Plan
Context (originally posted in #wg-frontend on slack)

Anyone have thoughts on the sass-loader legacy JS API deprecation? A warning pops up when running MFEs locally. There are some details about it here https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers

A warning pops up when running MFEs locally. There are some details about it here https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers

It seems to boil down to:

I see 2 options:

OR

  • Upgrade sass-loader (and maybe use sass-embedded? https://webpack.js.org/loaders/sass-loader/#api notes "Using modern-compiler and sass-embedded together significantly improve performance and decrease built time. We strongly recommend their use. We will enable them by default in a future major release."

I'm leaning towards silencing the deprecation warning until we cut Teak and upgrading for Ulmo, but I'm very open to hearing other thoughts on the matter!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json, where sass-loader 13.3.3 is declared, and read the linked sass-loader and Sass legacy JS API documentation. Determine the intended upgrade path, then run the local MFE build to verify the deprecation warning is addressed and the build still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, sass
Domain
build-system, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.