openedx / openedx/frontend-base
Replace `min-vh-100` with `dvh` to better support mobile
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 13
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 10
Description
uses 100vh (via min-vh-100). vh doesn't account for mobile UI elements.
I made a Paragon issue for adding min-dvh-* utility classes
Once that's discussed/lands then updating this to use the new dvh class would be awesome.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with shell/DefaultLayout.tsx at line 6 and review Paragon issue 3985, which tracks the required min-dvh-* utility classes. Once that utility is available, replace the existing min-vh-100 usage and verify that the default layout uses dynamic viewport height on mobile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100