openedx / openedx/frontend-app-authoring
patchability of UPLOAD_FILE_MAX_SIZE
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 17
- Forks
- 218
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 20
Description
Hi all, so sorry if I've logged this to the wrong place, or I'm being an idiot and there is a way to do this that I'm completely missing
In frontend-app-authoring/src/constants.js#L55 we have a constant "UPLOAD_FILE_MAX_SIZE = 20 * 1024 * 1024"
Insofar as I've found, there's no way to easily override this value without forking the repo and manually editing this value.
This breaks compatibility of the legacy patch (without MFE)
Is it possible that a patch can be implemented for the override of this value?
Or, perhaps a viable patch option would be to read the value of MAX_ASSET_UPLOAD_FILE_SIZE_IN_MB stored in "cms/envs/tutor/production.py" (already patchable via via the legacy openedx-cms-production-settings) to keep the contentstore.new_studio_mfe.use_new_files_uploads_page consistent with the old patch.
Here is a link to a discussion I opened and my findings
https://discuss.openedx.org/t/correctly-patch-max-asset-upload-file-size-in-mb/14572/5
There was another user who asked an equivalent question here, which I linked back to my above post:
https://discuss.openedx.org/t/max-asset-upload-file-size-in-mb-in-sumac-version/14930
Thanks for your consideration :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading frontend-app-authoring/src/constants.js around UPLOAD_FILE_MAX_SIZE and compare it with cms/envs/tutor/production.py, where MAX_ASSET_UPLOAD_FILE_SIZE_IN_MB is configured. Review the linked discussion and existing patch behavior to determine how the frontend value should be overridden. Done means the new files upload page remains consistent with the legacy patchable setting without requiring a fork.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100