opendevstack / opendevstack/ods-quickstarters
update nginx related quickstarters to support autodiscovery of services for APM solutions
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 39
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
When using a quickstarter that runs nginx most of the APM solutions out there that implement autodiscovery define the service discovered name as "_" or "localhost". It should have a better meaningful name like "gateway" or "nginx" or the name of the quickstarter like "nginx-ionic" or "gateway-ionic".
Describe the solution you'd like
Set the nginx.conf attribute "service_name" to something meaningful instead of "_".
Describe alternatives you've considered
I would like to gather some suggestions to not only be me deciding on what names should be the default.
Additional context
So far, this happens in:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the nginx configuration files in be-gateway-nginx/files/docker/nginx.conf, fe-ionic/files/docker/nginx.vh.default.conf.nginx, and fe-angular/files/docker/nginx.vh.default.conf.nginx. Compare their current service_name settings and review the existing issue discussion before choosing a consistent naming approach. Done means all three quickstarters use meaningful service names for APM autodiscovery.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100