opendevstack / opendevstack/ods-core
import_ocp_project_metadata.sh uses hard coded default administrator
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 53
- Forks
- 34
- Avg merge
- 3h 26m
- Merged PRs (30d)
- 1
Description
Describe the bug
If no project administrator is defined, the script
import_ocp_project_metadata.sh falls back to user utschig.
Other companys may want to have other default admin user.
To Reproduce
Do not specify paramter OD_PRJ_ADMINS when calling script
Expected behavior
Unclear what should be the expected behaivor.
Suggestion: Script should fail if no admin is defined
Affected version (please complete the following information):
- OpenDevStack [current master]
Additional context
Code snippet (line 135)
if [[ -z ${OD_PRJ_ADMINS} ]]; then
# fallback
echo ">>> no project admins set - setting clemens :)"
echo
OD_PRJ_ADMINS=utschig
else
# prepend clemens' account
OD_PRJ_ADMINS=utschig,${OD_PRJ_ADMINS}
fi
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ocp-templates/scripts/import_ocp_project_metadata.sh, around line 135, and reproduce the behavior by omitting OD_PRJ_ADMINS. Confirm the intended behavior with the maintainers, then ensure the script no longer relies on the hard-coded administrator and that the agreed missing-admin behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100