opendevstack / opendevstack/ods-core

Make location of caCert, tokenFile and namespaceFile configurable in Webhook Proxy

Open
#147 2 comments 2 reactions 1 assignee View on GitHub

@ungerts is already working on this.

Since Jul 11, 2019.

Dominant language
Shell
Stars
53
Forks
34
Avg merge
3h 26m
Merged PRs (30d)
1

Description

Locations of caCert, tokenFile and namespaceFile are currently hard coded in main.go. Making these locations configurable would allow for easier setup of local dev environments.

Proposal is:

namespaceFileDefault  = "/var/run/secrets/kubernetes.io/serviceaccount/namespace"
namespaceFileEnvVar   = "NAMESPACE_FILE"
tokenFileDefault      = "/var/run/secrets/kubernetes.io/serviceaccount/token"
tokenFileEnvVar       = "TOKEN_FILE"
caCertDefault         = "/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"
caCertEnvVar          = "CA_CERT_FILE"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.