opencontainers / opencontainers/runc

Joining existing pid ns not reparenting process

Open
#971 14 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.5k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
30

Description

We must be missing the double fork, like in the exec case, to reparent the process to the container's pid 1.

See https://github.com/docker/docker/issues/25348 for more details.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Read the linked Docker issue, then locate runc's existing exec-case process handling and compare it with joining an existing PID namespace. Done means the joined process is reparented to the container's PID 1 and the behavior has regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.