opencontainers / opencontainers/runc
exec.fifo handling is way too complicated
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.5k
- Forks
- 2.3k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 30
Description
We've added more and more layers of cruft to the exec.fifo management that just make the code really quite hard to follow (even just awaitFifoOpen is fairly funky).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the exec.fifo management and reading awaitFifoOpen, which the issue identifies as especially difficult to follow. Map the existing layers and their interactions before deciding how to simplify them. Done means the management flow is easier to understand while preserving the existing exec.fifo behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100